lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 04/17] misc/habana: Use FOLL_LONGTERM for userptr
    On Thu, Nov 19, 2020 at 4:41 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
    >
    > These are persistent, not just for the duration of a dma operation.
    >
    > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
    > Cc: Jason Gunthorpe <jgg@ziepe.ca>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: John Hubbard <jhubbard@nvidia.com>
    > Cc: Jérôme Glisse <jglisse@redhat.com>
    > Cc: Jan Kara <jack@suse.cz>
    > Cc: Dan Williams <dan.j.williams@intel.com>
    > Cc: linux-mm@kvack.org
    > Cc: linux-arm-kernel@lists.infradead.org
    > Cc: linux-samsung-soc@vger.kernel.org
    > Cc: linux-media@vger.kernel.org
    > Cc: Oded Gabbay <oded.gabbay@gmail.com>
    > Cc: Omer Shpigelman <oshpigelman@habana.ai>
    > Cc: Ofir Bitton <obitton@habana.ai>
    > Cc: Tomer Tayar <ttayar@habana.ai>
    > Cc: Moti Haimovski <mhaimovski@habana.ai>
    > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: Pawel Piskorski <ppiskorski@habana.ai>
    > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    > ---
    > drivers/misc/habanalabs/common/memory.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
    > index 0b220221873d..d08c41b90fec 100644
    > --- a/drivers/misc/habanalabs/common/memory.c
    > +++ b/drivers/misc/habanalabs/common/memory.c
    > @@ -1298,7 +1298,8 @@ static int get_user_memory(struct hl_device *hdev, u64 addr, u64 size,
    > return -ENOMEM;
    > }
    >
    > - rc = pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE,
    > + rc = pin_user_pages_fast(start, npages,
    > + FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
    > userptr->pages);
    >
    > if (rc != npages) {
    > --
    > 2.29.2
    >

    This patch and the previous one (03/17 misc/habana: Stop using
    frame_vector helpers) are both:
    Reviewed-by: Oded Gabbay <ogabbay@kernel.org>

    Thanks,
    Oded

    \
     
     \ /
      Last update: 2020-11-21 11:17    [W:4.245 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site