Messages in this thread | | | Subject | Re: [PATCH] checkpatch: add --fix option for INCLUDE_LINUX | From | Joe Perches <> | Date | Sat, 21 Nov 2020 12:05:22 -0800 |
| |
On Sat, 2020-11-21 at 21:47 +0530, Dwaipayan Ray wrote: > Provide fix option to INCLUDE_LINUX check to replace asm > includes. > > Macros of type: > #include <asm/percpu.h> > > are corrected to: > #include <linux/percpu.h> [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5468,8 +5468,11 @@ sub process { > CHK("ARCH_INCLUDE_LINUX", > "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr); > } else { > - WARN("INCLUDE_LINUX", > - "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr); > + if (WARN("INCLUDE_LINUX", > + "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr) && > + $fix) { > + $fixed[$fixlinenr] =~ s/\<asm\/$file\>/\<linux\/$file\>/;
$file can include a slash.
e.g.: arch/arm/kernel/atags_parse.c:#include <asm/mach/arch.h>
Probably simpler to use /Q /E quoting.
| |