Messages in this thread | | | From | "Patel, Utkarsh H" <> | Subject | RE: [PATCH v3 1/4] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message | Date | Fri, 20 Nov 2020 17:04:17 +0000 |
| |
Hi Heikki and Prashant,
Thank you for the feedback.
> > > > include/linux/usb/typec.h | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h > > > > index 6be558045942..25731ed863fa 100644 > > > > --- a/include/linux/usb/typec.h > > > > +++ b/include/linux/usb/typec.h > > > > @@ -75,6 +75,10 @@ enum typec_orientation { > > > > /* > > > > * struct enter_usb_data - Enter_USB Message details > > > > * @eudo: Enter_USB Data Object > > > > + * @tbt_cable_vdo: TBT3 Cable Discover Mode Response > > > > > > This is fine.. > > > > > > > + * @tbt_cable_vdo needs to be filled with details of active cable > > > > + plug link > > > > + * training and cable rounded support when thunderbolt 3 cable is > > > > + being used to > > > > + * create USB4 connection. Do not fill this in case of USB4 cable. > > > > > > But this is not. The description of the member tells what the member > > > contains, but it does not make sense to explain also how to use the > > > member in the same place. > > > > Slightly tangential question here: > > > > Is there a need to mention "active cable plug link training" and > > "cable rounded support" at all? Wouldn't it be sufficient to omit > > those in the description (in case some mux implementation wants to use > > the other fields of the VDO) ? > > No, I don't think so. I think it would be enough to just mention that we need > the TBT3 Cable VDO only when the USB4 connection is created using TBT3 > cables. And that's it.
Ack.
> > > Br, > > -- > Heikki
Sincerely, Utkarsh Patel.
| |