Messages in this thread | | | Subject | Re: [PATCH 1/3] dt-bindings: pci: ti,j721e: Fix "ti,syscon-pcie-ctrl" to take argument | From | Kishon Vijay Abraham I <> | Date | Fri, 20 Nov 2020 10:39:19 +0530 |
| |
Hi Rob,
On 19/11/20 2:41 am, Rob Herring wrote: > On Mon, Nov 16, 2020 at 11:01:39PM +0530, Kishon Vijay Abraham I wrote: >> Fix binding documentation of "ti,syscon-pcie-ctrl" to take phandle with >> argument. The argument is the register offset within "syscon" used to >> configure PCIe controller. >> >> Link: Link: http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com > > Link: Link: ? > > AIUI, 'Link' is supposed to be a link to this patch. I guess more than 1 > Link would be okay though.
Two Links was a typo, will fix it in the next revision. Nishanth as well was asking about using "Link:" tag for a mailing list discussion.
I started using it after Lorenzo had asked me to use Link tag for mailing list discussion here sometime back.
https://patchwork.kernel.org/project/linux-pci/patch/20171219083627.7904-1-kishon@ti.com/#21350261
> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> .../devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 12 ++++++++---- >> .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 12 ++++++++---- >> 2 files changed, 16 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> index 3ae3e1a2d4b0..e9685c0bdc3e 100644 >> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> @@ -29,9 +29,13 @@ properties: >> - const: mem >> >> ti,syscon-pcie-ctrl: >> - description: Phandle to the SYSCON entry required for configuring PCIe mode >> - and link speed. >> - $ref: /schemas/types.yaml#/definitions/phandle >> + allOf: > > You no longer need allOf here.
hmm, don't we need it for specifying phandle with fixed cells? FWIW, I was referring
https://github.com/devicetree-org/dt-schema/blob/master/test/schemas/good-example.yaml#L187
Thank You, Kishon
| |