Messages in this thread | | | Subject | Re: [PATCH 1/2] x86/intel_rdt: Check monitor group vs control group membership earlier | From | James Morse <> | Date | Fri, 20 Nov 2020 14:53:15 +0000 |
| |
Hi Valentin,
On 18/11/2020 18:00, Valentin Schneider wrote: > A task can only be moved between monitor groups if both groups belong to > the same control group. This is checked fairly late however: by that time > we already have appended a task_work() callback.
(is that a problem? It's needed to do the kfree())
> Check the validity of the move before getting anywhere near task_work > callbacks.
This saves the kzalloc()/task_work_add() if it wasn't going to be necessary.
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
| |