lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()
On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

> > if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0 &&
> > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) {
> > dev_err(&pdev->dev, "System does not support DMA, aborting\n");
> > + rc = -EIO;
> > goto init_err_disable;

Edwin, please double check if this shouldn't jump to
pci_release_regions() (or maybe it's harmless 'cause
PCI likes to magically release things on its own).

> > }
>
> Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Applied thanks!

\
 
 \ /
  Last update: 2020-11-20 06:54    [W:0.475 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site