lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands
On Fri, 20 Nov 2020 21:31:09 -0600 Alex Elder wrote:
> On 11/20/20 8:49 PM, Jakub Kicinski wrote:
> > On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote:
> >> + do
> >> + ret = gsi_generic_command(gsi, channel_id,
> >> + GSI_GENERIC_HALT_CHANNEL);
> >> + while (ret == -EAGAIN && retries--);
> >
> > This may well be the first time I've seen someone write a do while loop
> > without the curly brackets!
>
> I had them at one time, then saw I could get away
> without them. I don't have a preference but I see
> you accepted it as-is.

It was just an offhand comment, I don't have anything against it :)

\
 
 \ /
  Last update: 2020-11-21 04:49    [W:0.064 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site