Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 20 Nov 2020 15:58:56 -0800 | Subject | Re: [PATCH v2 01/24] exec: Move unshare_files to fix posix file locking during exec |
| |
On Fri, Nov 20, 2020 at 3:16 PM Eric W. Biederman <ebiederm@xmission.com> wrote: > > @@ -1257,6 +1258,13 @@ int begin_new_exec(struct linux_binprm * bprm) > if (retval) > goto out; > > + /* Ensure the files table is not shared. */ > + retval = unshare_files(&displaced); > + if (retval) > + goto out; > + if (displaced) > + put_files_struct(displaced);
It's not obvious from the patch (not enough context), but the new placement seems to make much more sense - and it's where we do the de-thread and switch the vm and signals too.
So this does seem to be the much more logical place.
Ack.
Linus
| |