lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 5/8] rpmsg: core: Add channel creation internal API
    Date
    From: Arnaud Pouliquen <arnaud.pouliquen@st.com>

    Add the channel creation API as a first step to be able to define the
    name service announcement as a rpmsg driver independent from the RPMsg
    virtio bus.

    Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    ---
    drivers/rpmsg/rpmsg_core.c | 44 ++++++++++++++++++++++++++++++++++
    drivers/rpmsg/rpmsg_internal.h | 10 ++++++++
    2 files changed, 54 insertions(+)

    diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
    index 91de940896e3..e5daee4f9373 100644
    --- a/drivers/rpmsg/rpmsg_core.c
    +++ b/drivers/rpmsg/rpmsg_core.c
    @@ -20,6 +20,50 @@

    #include "rpmsg_internal.h"

    +/**
    + * rpmsg_create_channel() - create a new rpmsg channel
    + * using its name and address info.
    + * @rpdev: rpmsg device
    + * @chinfo: channel_info to bind
    + *
    + * Returns a pointer to the new rpmsg device on success, or NULL on error.
    + */
    +struct rpmsg_device *rpmsg_create_channel(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo)
    +{
    + if (WARN_ON(!rpdev))
    + return NULL;
    + if (!rpdev->ops || !rpdev->ops->create_channel) {
    + dev_err(&rpdev->dev, "no create_channel ops found\n");
    + return NULL;
    + }
    +
    + return rpdev->ops->create_channel(rpdev, chinfo);
    +}
    +EXPORT_SYMBOL(rpmsg_create_channel);
    +
    +/**
    + * rpmsg_release_channel() - release a rpmsg channel
    + * using its name and address info.
    + * @rpdev: rpmsg device
    + * @chinfo: channel_info to bind
    + *
    + * Returns 0 on success or an appropriate error value.
    + */
    +int rpmsg_release_channel(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo)
    +{
    + if (WARN_ON(!rpdev))
    + return -EINVAL;
    + if (!rpdev->ops || !rpdev->ops->release_channel) {
    + dev_err(&rpdev->dev, "no release_channel ops found\n");
    + return -ENXIO;
    + }
    +
    + return rpdev->ops->release_channel(rpdev, chinfo);
    +}
    +EXPORT_SYMBOL(rpmsg_release_channel);
    +
    /**
    * rpmsg_create_ept() - create a new rpmsg_endpoint
    * @rpdev: rpmsg channel device
    diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h
    index 3fc83cd50e98..f1de73e0f2d6 100644
    --- a/drivers/rpmsg/rpmsg_internal.h
    +++ b/drivers/rpmsg/rpmsg_internal.h
    @@ -20,6 +20,8 @@

    /**
    * struct rpmsg_device_ops - indirection table for the rpmsg_device operations
    + * @create_channel: create backend-specific channel, optional
    + * @release_channel: release backend-specific channel, optional
    * @create_ept: create backend-specific endpoint, required
    * @announce_create: announce presence of new channel, optional
    * @announce_destroy: announce destruction of channel, optional
    @@ -29,6 +31,10 @@
    * advertise new channels implicitly by creating the endpoints.
    */
    struct rpmsg_device_ops {
    + struct rpmsg_device *(*create_channel)(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo);
    + int (*release_channel)(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo);
    struct rpmsg_endpoint *(*create_ept)(struct rpmsg_device *rpdev,
    rpmsg_rx_cb_t cb, void *priv,
    struct rpmsg_channel_info chinfo);
    @@ -75,6 +81,10 @@ int rpmsg_unregister_device(struct device *parent,
    struct device *rpmsg_find_device(struct device *parent,
    struct rpmsg_channel_info *chinfo);

    +struct rpmsg_device *rpmsg_create_channel(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo);
    +int rpmsg_release_channel(struct rpmsg_device *rpdev,
    + struct rpmsg_channel_info *chinfo);
    /**
    * rpmsg_chrdev_register_device() - register chrdev device based on rpdev
    * @rpdev: prepared rpdev to be used for creating endpoints
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-20 22:44    [W:2.596 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site