lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH\ net] rtw88: fix fw dump support detection
From
Date
Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> clang points out a useless check that was recently added:
>
> drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (!rtwdev->chip->fw_fifo_addr) {
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~
>
> Apparently this was meant to check the contents of the array
> rather than the address, so check it accordingly.
>
> Fixes: 0fbc2f0f34cc ("rtw88: add dump firmware fifo support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

I'll take Tom's patch as it was first.

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20201026212323.3888550-1-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-11-02 19:14    [W:0.043 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site