lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 21/29] scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume
    Date
    The driver calls pci_enable_wake(...., false) in twa_resume(), and
    there is no corresponding pci_enable_wake(...., true) in twa_suspend().
    Either it should do enable-wake the device in .suspend() or should not
    invoke pci_enable_wake() at all.

    Concluding that this driver doesn't support enable-wake and PCI core calls
    pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
    twa_resume().

    Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
    Acked-by: Don Brace <don.brace@microchip.com>
    ---
    drivers/scsi/3w-9xxx.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
    index 3337b1e80412..e458e99ff161 100644
    --- a/drivers/scsi/3w-9xxx.c
    +++ b/drivers/scsi/3w-9xxx.c
    @@ -2230,7 +2230,6 @@ static int twa_resume(struct pci_dev *pdev)

    printk(KERN_WARNING "3w-9xxx: Resuming host %d.\n", tw_dev->host->host_no);
    pci_set_power_state(pdev, PCI_D0);
    - pci_enable_wake(pdev, PCI_D0, 0);
    pci_restore_state(pdev);

    retval = pci_enable_device(pdev);
    --
    2.28.0
    \
     
     \ /
      Last update: 2020-11-02 17:55    [W:4.743 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site