Messages in this thread Patch in this message | | | From | Vaibhav Gupta <> | Subject | [PATCH v4 18/29] scsi: pm_8001: Drop PCI Wakeup calls from .resume | Date | Mon, 2 Nov 2020 22:17:19 +0530 |
| |
The driver calls pci_enable_wake(...., false) in pm8001_pci_resume(), and there is no corresponding pci_enable_wake(...., true) in pm8001_pci_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all.
Concluding that this driver doesn't support enable-wake and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from pm8001_pci__resume().
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com> --- drivers/scsi/pm8001/pm8001_init.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 3cf3e58b6979..d47ed9a33173 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -1327,7 +1327,6 @@ static int pm8001_pci_resume(struct pci_dev *pdev) "operating state [D%d]\n", pdev, pm8001_ha->name, device_state); pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); rc = pci_enable_device(pdev); if (rc) { -- 2.28.0
| |