Messages in this thread | | | Date | Mon, 2 Nov 2020 11:19:08 -0500 | From | Masayoshi Mizuma <> | Subject | Re: [PATCH v7 3/7] arm64: smp: Assign and setup an IPI as NMI |
| |
On Mon, Nov 02, 2020 at 05:14:43PM +0530, Sumit Garg wrote: > Assign an unused IPI which can be turned as NMI using ipi_nmi framework. > Also, invoke corresponding dynamic IPI setup/teardown APIs. > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org> > --- > arch/arm64/kernel/smp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 82e75fc..2e118e2 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -43,6 +43,7 @@ > #include <asm/daifflags.h> > #include <asm/kvm_mmu.h> > #include <asm/mmu_context.h> > +#include <asm/nmi.h> > #include <asm/numa.h> > #include <asm/processor.h> > #include <asm/smp_plat.h> > @@ -962,6 +963,8 @@ static void ipi_setup(int cpu) > > for (i = 0; i < nr_ipi; i++) > enable_percpu_irq(ipi_irq_base + i, 0); > + > + dynamic_ipi_setup(cpu); > } > > #ifdef CONFIG_HOTPLUG_CPU > @@ -974,6 +977,8 @@ static void ipi_teardown(int cpu) > > for (i = 0; i < nr_ipi; i++) > disable_percpu_irq(ipi_irq_base + i); > + > + dynamic_ipi_teardown(cpu); > } > #endif > > @@ -995,6 +1000,9 @@ void __init set_smp_ipi_range(int ipi_base, int n) > irq_set_status_flags(ipi_base + i, IRQ_HIDDEN); > } > > + if (n > nr_ipi) > + set_smp_dynamic_ipi(ipi_base + nr_ipi); > + > ipi_irq_base = ipi_base; > > /* Setup the boot CPU immediately */ > --
Looks good to me. Please feel free to add:
Reviewed-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Thanks! Masa
| |