lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
    Hi Lee,

    Lee Jones <lee.jones@linaro.org> wrote on Mon, 2 Nov 2020 11:54:06
    +0000:

    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device
    > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device
    > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device
    > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info'
    >
    > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
    > Cc: Richard Weinberger <richard@nod.at>
    > Cc: Vignesh Raghavendra <vigneshr@ti.com>
    > Cc: Michael Ellerman <mpe@ellerman.id.au>
    > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    > Cc: Paul Mackerras <paulus@samba.org>
    > Cc: Cyril Bur <cyril.bur@au1.ibm.com>
    > Cc: linux-mtd@lists.infradead.org
    > Cc: linuxppc-dev@lists.ozlabs.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/mtd/devices/powernv_flash.c | 6 +++++-
    > 1 file changed, 5 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
    > index 0b757d9ba2f6b..32cb0e649096f 100644
    > --- a/drivers/mtd/devices/powernv_flash.c
    > +++ b/drivers/mtd/devices/powernv_flash.c
    > @@ -126,6 +126,8 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op,
    > }
    >
    > /**
    > + * powernv_flash_read
    > + *

    Perhaps we should not add blank lines if the rest of the file does not
    already have such spacing (see below).

    > * @mtd: the device
    > * @from: the offset to read from
    > * @len: the number of bytes to read
    > @@ -142,6 +144,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len,
    > }
    >
    > /**
    > + * powernv_flash_write
    > * @mtd: the device
    > * @to: the offset to write to
    > * @len: the number of bytes to write
    > @@ -158,6 +161,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len,
    > }
    >
    > /**
    > + * powernv_flash_erase
    > * @mtd: the device
    > * @erase: the erase info
    > * Returns 0 if erase successful or -ERRNO if an error occurred
    > @@ -176,7 +180,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase)
    >
    > /**
    > * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3
    > - * structure @pdev: The platform device
    > + * @dev: The device structure
    > * @mtd: The structure to fill
    > */
    > static int powernv_flash_set_driver_info(struct device *dev,


    Thanks,
    Miquèl

    \
     
     \ /
      Last update: 2020-11-02 13:52    [W:3.968 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site