lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/41] iwlwifi: mvm: rs: Demote non-conformant function documentation headers
    Date
    Also add documentation for 'mvm'.

    Fixes the following W=1 kernel build warning(s):

    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:400: warning: cannot understand function prototype: 'const u16 expected_tpt_legacy[IWL_RATE_COUNT] = '
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'mvm' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'tbl' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'scale_index' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'attempts' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'successes' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'window' not described in '_rs_collect_tx_data'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2677: warning: duplicate section name 'NOTE'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'mvm' not described in 'rs_initialize_lq'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'sta' not described in 'rs_initialize_lq'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'lq_sta' not described in 'rs_initialize_lq'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'band' not described in 'rs_initialize_lq'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'mvm' not described in 'rs_program_fix_rate'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'lq_sta' not described in 'rs_program_fix_rate'
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c:4213: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_tx_protection'

    Cc: Johannes Berg <johannes.berg@intel.com>
    Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Cc: Luca Coelho <luciano.coelho@intel.com>
    Cc: Intel Linux Wireless <linuxwifi@intel.com>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: linux-wireless@vger.kernel.org
    Cc: netdev@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
    index ed7382e7ea177..91b6541d579f5 100644
    --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
    +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
    @@ -386,7 +386,7 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm,
    const struct rs_rate *initial_rate);
    static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search);

    -/**
    +/*
    * The following tables contain the expected throughput metrics for all rates
    *
    * 1, 2, 5.5, 11, 6, 9, 12, 18, 24, 36, 48, 54, 60 MBits
    @@ -396,7 +396,6 @@ static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search);
    * CCK rates are only valid in legacy table and will only be used in G
    * (2.4 GHz) band.
    */
    -
    static const u16 expected_tpt_legacy[IWL_RATE_COUNT] = {
    7, 13, 35, 58, 40, 57, 72, 98, 121, 154, 177, 186, 0, 0, 0
    };
    @@ -670,7 +669,7 @@ static s32 get_expected_tpt(struct iwl_scale_tbl_info *tbl, int rs_index)
    return 0;
    }

    -/**
    +/*
    * rs_collect_tx_data - Update the success/failure sliding window
    *
    * We keep a sliding window of the last 62 packets transmitted
    @@ -2667,7 +2666,7 @@ void rs_update_last_rssi(struct iwl_mvm *mvm,
    }
    }

    -/**
    +/*
    * rs_initialize_lq - Initialize a station's hardware rate table
    *
    * The uCode's station table contains a table of fallback rates
    @@ -3756,7 +3755,7 @@ int rs_pretty_print_rate(char *buf, int bufsz, const u32 rate)
    }

    #ifdef CONFIG_MAC80211_DEBUGFS
    -/**
    +/*
    * Program the device to use fixed rate for frame transmit
    * This is for debugging/testing only
    * once the device start use fixed rate, we need to reload the module
    @@ -4211,6 +4210,7 @@ static int rs_drv_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta,

    /**
    * iwl_mvm_tx_protection - ask FW to enable RTS/CTS protection
    + * @mvm: The mvm component
    * @mvmsta: The station
    * @enable: Enable Tx protection?
    */
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-02 12:29    [W:2.286 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site