lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/41] prism54: isl_ioctl: Fix one function header and demote another
    Date
    Fixes the following W=1 kernel build warning(s):

    from drivers/net/wireless/intersil/prism54/isl_ioctl.c:22:
    inlined from ‘prism54_get_name’ at drivers/net/wireless/intersil/prism54/isl_ioctl.c:283:2:
    drivers/net/wireless/intersil/prism54/isl_ioctl.c:68: warning: Function parameter or member 'priv' not described in 'prism54_mib_mode_helper'
    drivers/net/wireless/intersil/prism54/isl_ioctl.c:68: warning: Excess function parameter 'mib' description in 'prism54_mib_mode_helper'
    drivers/net/wireless/intersil/prism54/isl_ioctl.c:127: warning: Function parameter or member 'priv' not described in 'prism54_mib_init'

    Cc: Luis Chamberlain <mcgrof@kernel.org>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Aurelien Alleaume <slts@free.fr>
    Cc: Valerio Riedel <hvr@gnu.org>
    Cc: "Luis R. Rodriguez" <mcgrof@ruslug.rutgers.edu>
    Cc: linux-wireless@vger.kernel.org
    Cc: netdev@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/net/wireless/intersil/prism54/isl_ioctl.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/wireless/intersil/prism54/isl_ioctl.c b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
    index 2076f449b6e25..5e5ceafe098b9 100644
    --- a/drivers/net/wireless/intersil/prism54/isl_ioctl.c
    +++ b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
    @@ -54,7 +54,7 @@ static const unsigned char scan_rate_list[] = { 2, 4, 11, 22,

    /**
    * prism54_mib_mode_helper - MIB change mode helper function
    - * @mib: the &struct islpci_mib object to modify
    + * @priv: the &struct islpci_private object to modify
    * @iw_mode: new mode (%IW_MODE_*)
    *
    * This is a helper function, hence it does not lock. Make sure
    @@ -114,14 +114,13 @@ prism54_mib_mode_helper(islpci_private *priv, u32 iw_mode)
    return 0;
    }

    -/**
    +/*
    * prism54_mib_init - fill MIB cache with defaults
    *
    * this function initializes the struct given as @mib with defaults,
    * of which many are retrieved from the global module parameter
    * variables.
    */
    -
    void
    prism54_mib_init(islpci_private *priv)
    {
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-02 12:28    [W:4.175 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site