Messages in this thread | | | Subject | Re: [PATCH] gpu/drm: delete same check in if condition | From | Thomas Zimmermann <> | Date | Mon, 2 Nov 2020 09:20:08 +0100 |
| |
Hi
Am 02.11.20 um 04:07 schrieb Bernard Zhao: > In function drm_bridge_connector_get_modes_edid, drm_edid_is_valid > will check weather (!edid), no need to check again in the if > branch. > > Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks! I'll add the patch to drm-misc-next.
Best regards Thomas
> --- > drivers/gpu/drm/drm_bridge_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index a58cbde59c34..791379816837 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -241,7 +241,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector, > goto no_edid; > > edid = bridge->funcs->get_edid(bridge, connector); > - if (!edid || !drm_edid_is_valid(edid)) { > + if (!drm_edid_is_valid(edid)) { > kfree(edid); > goto no_edid; > } >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |