Messages in this thread | | | From | Brian Norris <> | Date | Mon, 2 Nov 2020 16:06:15 -0800 | Subject | Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown |
| |
On Mon, Nov 2, 2020 at 3:25 AM Lee Jones <lee.jones@linaro.org> wrote: > --- a/drivers/net/wireless/realtek/rtw88/pci.h > +++ b/drivers/net/wireless/realtek/rtw88/pci.h > @@ -212,6 +212,10 @@ struct rtw_pci { > void __iomem *mmap; > }; > > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); > +void rtw_pci_remove(struct pci_dev *pdev); > +void rtw_pci_shutdown(struct pci_dev *pdev); > + >
These definitions are already in 4 other header files:
drivers/net/wireless/realtek/rtw88/rtw8723de.h drivers/net/wireless/realtek/rtw88/rtw8821ce.h drivers/net/wireless/realtek/rtw88/rtw8822be.h drivers/net/wireless/realtek/rtw88/rtw8822ce.h
Seems like you should be moving them, not just adding yet another duplicate.
Brian
| |