Messages in this thread | | | Date | Tue, 3 Nov 2020 07:52:19 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o |
| |
On Mon, Nov 02, 2020 at 01:31:59PM -0800, Randy Dunlap wrote: > On 11/2/20 1:01 PM, Valdis Klētnieks wrote: > > On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said: > > > >> also > >> Reported-by: kernel test robot <lkp@intel.com> > >> > >> However, this driver does not directly use <linux/module.h>. > > > > Just my luck - I looked at 3 or 4 other things that include of_platform.h > > and they all *did* include module.h. > > > >> platform_device.h #includes <linux/device.h>, which is where the > >> problem lies: > >> > >> <linux/device.h> uses macros that are provided by <linux/module.h> > >> so <linux/device.h> should #include <linux/module.h>. > >> > >> and that fixes this commit: > >> > >> commit 4c002c978b7f2f2306d53de051c054504af920a9 > >> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > >> Date: Mon Dec 9 20:33:03 2019 +0100 > >> > >> device.h: move 'struct driver' stuff out to device/driver.h > > > > OK.. who's going to do that? Me, or Randy, or Greg? > > You could go ahead... I began on it yesterday but didn't finish > testing, although I did see the same build error that the 0day > bot reported, so I don't know what it's going to take to fix that.
It's a driver problem which is being addressed by Dong's patch[1].
Shawn
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201030153733.30160-1-aisheng.dong@nxp.com/
| |