Messages in this thread | | | Date | Mon, 2 Nov 2020 21:10:40 +0100 | From | Greg KH <> | Subject | Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL |
| |
On Mon, Nov 02, 2020 at 02:43:45PM -0500, Alex Deucher wrote: > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma <mh12gx2825@gmail.com> wrote: > > > > Initializing global variable to 0 or NULL is not necessary and should > > be avoided. Issue reported by checkpatch script as: > > ERROR: do not initialise globals to 0 (or NULL). > > I agree that this is technically correct, but a lot of people don't > seem to know that so we get a lot of comments about this code for the > variables that are not explicitly set. Seems less confusing to > initialize them even if it not necessary. I don't have a particularly > strong opinion on it however.
The kernel coding style is to do it this way. You even save space and time by doing it as well :)
thanks,
greg k-h
| |