Messages in this thread | | | Subject | Re: rtw88: fix fw_fifo_addr check | From | Kalle Valo <> | Date | Mon, 2 Nov 2020 18:16:53 +0000 (UTC) |
| |
trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com> > > The clang build reports this warning > > fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' > will always evaluate to 'true' > if (!rtwdev->chip->fw_fifo_addr) { > > fw_fifo_addr is an array in rtw_chip_info so it is always > nonzero. A better check is if the first element of the array is > nonzero. In the cases where fw_fifo_addr is initialized by rtw88b > and rtw88c, the first array element is 0x780. > > Fixes: 0fbc2f0f34cc ("rtw88: add dump firmware fifo support") > Signed-off-by: Tom Rix <trix@redhat.com> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > Acked-by: Tzu-En Huang <tehuang@realtek.com>
Patch applied to wireless-drivers.git, thanks.
ddcd945e556e rtw88: fix fw_fifo_addr check
-- https://patchwork.kernel.org/project/linux-wireless/patch/20201011155438.15892-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |