Messages in this thread | | | Subject | Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem | From | Maximilian Luz <> | Date | Thu, 19 Nov 2020 18:35:52 +0100 |
| |
On 11/19/20 4:54 PM, Barnabás Pőcze wrote: > Hi
[...]
>>>> +enum ssam_ssh_tc { >>>> + /* Known SSH/EC target categories. */ >>>> + // category 0x00 is invalid for EC use >>>> + SSAM_SSH_TC_SAM = 0x01, // generic system functionality, real-time clock >>>> + SSAM_SSH_TC_BAT = 0x02, // battery/power subsystem >>>> + SSAM_SSH_TC_TMP = 0x03, // thermal subsystem >>>> + SSAM_SSH_TC_PMC = 0x04, >>>> + SSAM_SSH_TC_FAN = 0x05, >>>> + SSAM_SSH_TC_PoM = 0x06, >>>> + SSAM_SSH_TC_DBG = 0x07, >>>> + SSAM_SSH_TC_KBD = 0x08, // legacy keyboard (Laptop 1/2) >>>> + SSAM_SSH_TC_FWU = 0x09, >>>> + SSAM_SSH_TC_UNI = 0x0a, >>>> + SSAM_SSH_TC_LPC = 0x0b, >>>> + SSAM_SSH_TC_TCL = 0x0c, >>>> + SSAM_SSH_TC_SFL = 0x0d, >>>> + SSAM_SSH_TC_KIP = 0x0e, >>>> + SSAM_SSH_TC_EXT = 0x0f, >>>> + SSAM_SSH_TC_BLD = 0x10, >>>> + SSAM_SSH_TC_BAS = 0x11, // detachment system (Surface Book 2/3) >>>> + SSAM_SSH_TC_SEN = 0x12, >>>> + SSAM_SSH_TC_SRQ = 0x13, >>>> + SSAM_SSH_TC_MCU = 0x14, >>>> + SSAM_SSH_TC_HID = 0x15, // generic HID input subsystem >>>> + SSAM_SSH_TC_TCH = 0x16, >>>> + SSAM_SSH_TC_BKL = 0x17, >>>> + SSAM_SSH_TC_TAM = 0x18, >>>> + SSAM_SSH_TC_ACC = 0x19, >>>> + SSAM_SSH_TC_UFI = 0x1a, >>>> + SSAM_SSH_TC_USC = 0x1b, >>>> + SSAM_SSH_TC_PEN = 0x1c, >>>> + SSAM_SSH_TC_VID = 0x1d, >>>> + SSAM_SSH_TC_AUD = 0x1e, >>>> + SSAM_SSH_TC_SMC = 0x1f, >>>> + SSAM_SSH_TC_KPD = 0x20, >>>> + SSAM_SSH_TC_REG = 0x21, >>>> +}; >>> >>> Is it known what these abbreviations stand for? Maybe I missed them? >> >> The comments state all we really know about these (through observation >> and experimentation). The table itself has been extracted from the >> Windows driver, but the abbreviations and values are all we're getting >> from it. > > I see, thanks for the clarification. For some reason, I believed the > "Known SSH/EC target categories" comment means that those are known, as in, > it is known what they are for, etc., not just the abbreviation.
Right, that can be misunderstood, sorry. It's probably best if I add a comment explaining that in a bit more detail and noting where those values and abbreviations come from.
Thanks, Max
| |