Messages in this thread | | | Subject | Re: Deadlock cpuctx_mutex / pmus_lock / &mm->mmap_lock#2 | From | Chris Wilson <> | Date | Thu, 19 Nov 2020 13:25:11 +0000 |
| |
Quoting Peter Zijlstra (2020-11-19 13:02:44) > > Chris, I suspect this is due to i915 calling stop machine with all sorts > of locks held. Is there anything to be done about this? stop_machine() > is really nasty to begin with. > > What problem is it typing to solve?
If there is any concurrent access through a PCI bar (that is exported to userspace via mmap) as the GTT is updated, results in undefined HW behaviour (where that is not limited to users writing to other system pages).
stop_machine() is the most foolproof method we know that works.
This particular cycle is easy to break by moving the copy_to_user to after releasing perf_event_ctx_unlock in perf_read(). -Chris
| |