Messages in this thread Patch in this message | | | Date | Thu, 19 Nov 2020 12:01:50 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH v3 5/6] firmware: arm_scmi: add SCMIv3.0 Sensor configuration support |
| |
On Wed, Nov 18, 2020 at 04:29:04PM +0000, Cristian Marussi wrote: > Add SCMIv3.0 Sensor support for CONFIG_GET/CONFIG_SET commands. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > drivers/firmware/arm_scmi/sensors.c | 75 +++++++++++++++++++++++++++++ > include/linux/scmi_protocol.h | 37 ++++++++++++++ > 2 files changed, 112 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index 0adc545116a4..fa3385045361 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -22,6 +22,8 @@ enum scmi_sensor_protocol_cmd { > SENSOR_READING_GET = 0x6, > SENSOR_AXIS_DESCRIPTION_GET = 0x7, > SENSOR_LIST_UPDATE_INTERVALS = 0x8, > + SENSOR_CONFIG_GET = 0x9, > + SENSOR_CONFIG_SET = 0xA, > }; > > struct scmi_msg_resp_sensor_attributes { > @@ -150,6 +152,19 @@ struct scmi_msg_set_sensor_trip_point { > __le32 value_high; > }; > > +struct scmi_msg_sensor_config_get { > + __le32 id; > +}; > + > +struct scmi_resp_sensor_config_get { > + __le32 sensor_config; > +}; > +
Same comment about single element structure as in previous patch.
-- Regards, Sudeep
| |