lkml.org 
[lkml]   [2020]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/6] ASoC: dt-bindings: tegra: Add graph bindings
From
Date
Hi Rob,

>> Add device tree binding properties of generic graph to ASoC component
>> devices. This allows to define audio ports out of these components or
>> DAIs and audio graph based sound card can be realised with this.
> This is all dependent on graph.yaml being applied which hasn't happened
> yet. I guess I'll need to provide a branch as there's multiple
> subsystems needing it.
>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> .../devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 6 ++++++
>> .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 6 ++++++
>> .../devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 13 +++++++++++--
>> .../devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 6 ++++++
>> .../devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 6 ++++++
>> 5 files changed, 35 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> index ed2fb32..3c9364d 100644
>> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> @@ -55,6 +55,12 @@ properties:
>> The name can be "DSPK1" or "DSPKx", where x depends on the maximum
>> available instances on a Tegra SoC.

>>
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
> If you have 'ports', then that means you have multiple ports and you
> have to enumerate what each port is.
>
>> +
>> + port:
>> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> If you only have 1 port then, you can use 'port'.
>
>
> So listing both is an error.

Since "ASoC: graph card schema rework" series is merged now, referencing
"audio-graph-port.yaml" should be sufficient here?

...

\
 
 \ /
  Last update: 2020-11-19 10:12    [W:0.073 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site