lkml.org 
[lkml]   [2020]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 2/4] net: phy: Add 5GBASER interface mode
    On Fri, Nov 20, 2020 at 10:25:33AM +1000, Pavana Sharma wrote:
    > Add 5GBASE-R phy interface mode
    >
    > Signed-off-by: Pavana Sharma <pavana.sharma@digi.com>
    > ---
    > include/linux/phy.h | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/include/linux/phy.h b/include/linux/phy.h
    > index eb3cb1a98b45..71e280059ec5 100644
    > --- a/include/linux/phy.h
    > +++ b/include/linux/phy.h
    > @@ -106,6 +106,7 @@ extern const int phy_10gbit_features_array[1];
    > * @PHY_INTERFACE_MODE_TRGMII: Turbo RGMII
    > * @PHY_INTERFACE_MODE_1000BASEX: 1000 BaseX
    > * @PHY_INTERFACE_MODE_2500BASEX: 2500 BaseX
    > + * @PHY_INTERFACE_MODE_5GBASER: 5G BaseR
    > * @PHY_INTERFACE_MODE_RXAUI: Reduced XAUI
    > * @PHY_INTERFACE_MODE_XAUI: 10 Gigabit Attachment Unit Interface
    > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR
    > @@ -137,6 +138,8 @@ typedef enum {
    > PHY_INTERFACE_MODE_TRGMII,
    > PHY_INTERFACE_MODE_1000BASEX,
    > PHY_INTERFACE_MODE_2500BASEX,
    > + /* 5GBASE-R mode */
    > + PHY_INTERFACE_MODE_5GBASER,


    Again, what is the value of the comment? 10GBASE-R has a comment
    because it is different from the rest, XFI and SFI caused a of
    discussion, and it was used wrong. But there does not seem to be
    anything special for 5GBASE-R.

    Andrew

    \
     
     \ /
      Last update: 2020-11-20 01:58    [W:2.444 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site