Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH v3 15/23] mtd: rawnand: diskonchip: Marking unused variables as __always_unused | Date | Thu, 19 Nov 2020 22:08:37 +0100 |
| |
On Mon, 2020-11-09 at 18:21:58 UTC, Lee Jones wrote: > 'dummy' is never checked (as per the nomenclature) and the use of > 'emtpymatch' is currently #if 0'ed out. We could also #if 0 the > declaration, but #ifery is pretty ugly, so I like to keep it to a > minimum. > > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/nand/raw/diskonchip.c: In function ‘DoC_Delay’: > drivers/mtd/nand/raw/diskonchip.c:219:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] > drivers/mtd/nand/raw/diskonchip.c: In function ‘doc200x_calculate_ecc’: > drivers/mtd/nand/raw/diskonchip.c:706:6: warning: variable ‘emptymatch’ set but not used [-Wunused-but-set-variable] > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Boris Brezillon <boris.brezillon@collabora.com> > Cc: Dan Brown <dan_brown@ieee.org> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
| |