lkml.org 
[lkml]   [2020]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: fsl_sai: Correct the clock source for mclk0
    On Thu, Nov 19, 2020 at 10:29:16AM +0800, Shengjiu Wang wrote:
    > On VF610, mclk0 = bus_clk;
    > On i.MX6SX/6UL/6ULL/7D, mclk0 = mclk1;
    > On i.MX7ULP, mclk0 = bus_clk;
    > On i.MX8QM/8QXP, mclk0 = bus_clk;
    > On i.MX8MQ/8MN/8MM/8MP, mclk0 = bus_clk;
    >
    > So add variable mclk0_mclk1_match in fsl_sai_soc_data To

    Not in favor of "mclk0_mclk1_match" as it doesn't sound explicit
    to me. Instead, "mclk0_is_bus_clk" or "mclk0_is_mclk1" might be
    better. Or in case that you foresee some other implementation:

    enum {
    MCLK0_IS_BUS_CLK,
    MCLK0_IS_MCLK1,
    };

    static const struct fsl_sai_soc_data fsl_sai_vf610_data = {
    + .mclk0_alias = MCLK0_IS_BUS_CLK,
    };

    \
     
     \ /
      Last update: 2020-11-19 06:02    [W:3.417 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site