Messages in this thread | | | Subject | Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply | From | Christian König <> | Date | Wed, 18 Nov 2020 09:17:49 +0100 |
| |
Am 18.11.20 um 03:55 schrieb Bernard Zhao: > Fix check_patch.pl warning: > WARNING: Prefer kmalloc_array over kmalloc with multiply > +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL); > WARNING: Prefer kmalloc_array over kmalloc with multiply > +bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), > GFP_KERNEL); > kmalloc_array has multiply overflow check, which will be safer. > > Signed-off-by: Bernard Zhao <bernard@vivo.com>
Not userspace controllable values, but looks cleaner anyway.
Reviewed-by: Christian König <christian.koenig@amd.com>
> --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index d0aea5e39531..f2a0851c804f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -280,8 +280,8 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev) > if (!*data) > return -ENOMEM; > > - bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL); > - bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KERNEL); > + bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL); > + bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), GFP_KERNEL); > > if (!bps || !bps_bo) { > kfree(bps);
| |