Messages in this thread | | | From | Abhishek Kumar <> | Date | Wed, 18 Nov 2020 16:20:58 -0800 | Subject | Re: [PATCH v3] ath10k: Fix the parsing error in service available event |
| |
Hi,
The patch LGTM there is small nit, though. > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -5751,8 +5751,13 @@ void ath10k_wmi_event_service_available(struct ath10k *ar, struct sk_buff *skb) > ret); > } > > - ath10k_wmi_map_svc_ext(ar, arg.service_map_ext, ar->wmi.svc_map, > - __le32_to_cpu(arg.service_map_ext_len)); > + /* > + * Initialization of "arg.service_map_ext_valid" to ZERO is necessary > + * for the below logic to work. > + */
Nit: The comment will throw a checkpatch warning. "networking block comments don't use an empty /* line, use /* Comment..."
-Abhishek
| |