lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 016/255] usb: gadget: fsl: fix null pointer checking
    Date
    From: Ran Wang <ran.wang_1@nxp.com>

    [ Upstream commit 48e7bbbbb261b007fe78aa14ae62df01d236497e ]

    fsl_ep_fifo_status() should return error if _ep->desc is null.

    Fixes: 75eaa498c99e (“usb: gadget: Correct NULL pointer checking in fsl gadget”)
    Reviewed-by: Peter Chen <peter.chen@nxp.com>
    Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
    index a6f7b2594c090..c0cb007b749ff 100644
    --- a/drivers/usb/gadget/udc/fsl_udc_core.c
    +++ b/drivers/usb/gadget/udc/fsl_udc_core.c
    @@ -1051,7 +1051,7 @@ static int fsl_ep_fifo_status(struct usb_ep *_ep)
    u32 bitmask;
    struct ep_queue_head *qh;

    - if (!_ep || _ep->desc || !(_ep->desc->bEndpointAddress&0xF))
    + if (!_ep || !_ep->desc || !(_ep->desc->bEndpointAddress&0xF))
    return -ENODEV;

    ep = container_of(_ep, struct fsl_ep, ep);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-17 14:52    [W:4.058 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site