Messages in this thread | | | From | David Gow <> | Date | Tue, 17 Nov 2020 15:20:53 +0800 | Subject | Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing |
| |
On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.arpi@gmail.com> wrote: > > Implementation of support for parameterized testing in KUnit. This > approach requires the creation of a test case using the > KUNIT_CASE_PARAM() macro that accepts a generator function as input. > > This generator function should return the next parameter given the > previous parameter in parameterized tests. It also provides a macro to > generate common-case generators based on arrays. Generators may also > optionally provide a human-readable description of parameters, which is > displayed where available. > > Note, currently the result of each parameter run is displayed in > diagnostic lines, and only the overall test case output summarizes > TAP-compliant success or failure of all parameter runs. In future, when > supported by kunit-tool, these can be turned into subsubtest outputs. > > Signed-off-by: Arpitha Raghunandan <98.arpi@gmail.com> > Co-developed-by: Marco Elver <elver@google.com> > Signed-off-by: Marco Elver <elver@google.com> > --- [Resending this because my email client re-defaulted to HTML! Aarrgh!]
This looks good to me! I tested it in UML and x86-64 w/ KASAN, and both worked fine.
Reviewed-by: David Gow <davidgow@google.com> Tested-by: David Gow <davidgow@google.com>
Thanks for sticking with this!
-- David
| |