lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 083/101] pinctrl: amd: use higher precision for 512 RtcClk
    Date
    From: Coiby Xu <coiby.xu@gmail.com>

    commit c64a6a0d4a928c63e5bc3b485552a8903a506c36 upstream.

    RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation
    likely has dropped precision and that's why the driver mistakenly took
    the slightly deviated value.

    Cc: stable@vger.kernel.org
    Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Suggested-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933b6c@redhat.com/
    Link: https://lore.kernel.org/r/20201105231912.69527-3-coiby.xu@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/pinctrl-amd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/pinctrl/pinctrl-amd.c
    +++ b/drivers/pinctrl/pinctrl-amd.c
    @@ -157,7 +157,7 @@ static int amd_gpio_set_debounce(struct
    pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);
    pin_reg &= ~BIT(DB_TMR_LARGE_OFF);
    } else if (debounce < 250000) {
    - time = debounce / 15600;
    + time = debounce / 15625;
    pin_reg |= time & DB_TMR_OUT_MASK;
    pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);
    pin_reg |= BIT(DB_TMR_LARGE_OFF);

    \
     
     \ /
      Last update: 2020-11-17 14:23    [W:4.211 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site