lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 37/85] nbd: fix a block_device refcount leak in nbd_release
    Date
    From: Christoph Hellwig <hch@lst.de>

    [ Upstream commit 2bd645b2d3f0bacadaa6037f067538e1cd4e42ef ]

    bdget_disk needs to be paired with bdput to not leak a reference
    on the block device inode.

    Fixes: 08ba91ee6e2c ("nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.")
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Josef Bacik <josef@toxicpanda.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/block/nbd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
    index 9a0fb2d52a76c..70ef826af7f8d 100644
    --- a/drivers/block/nbd.c
    +++ b/drivers/block/nbd.c
    @@ -1432,6 +1432,7 @@ static void nbd_release(struct gendisk *disk, fmode_t mode)
    if (test_bit(NBD_DISCONNECT_ON_CLOSE, &nbd->config->runtime_flags) &&
    bdev->bd_openers == 0)
    nbd_disconnect_and_put(nbd);
    + bdput(bdev);

    nbd_config_put(nbd);
    nbd_put(nbd);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-17 14:18    [W:4.130 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site