Messages in this thread | | | Date | Tue, 17 Nov 2020 14:22:14 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH v2 8/8] usb: typec: Remove active_link_training variable from Enter_USB message |
| |
On Fri, Nov 13, 2020 at 12:25:03PM -0800, Utkarsh Patel wrote: > Thunderbolt 3 cable discover mode VDO support has been added as part of > Enter_USB message to fill details of active cable plug link training. > Hence, removing unused variable active_link_training from Enter_USB > message data structure. > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> -- > Changes in v2: > - No change. > -- > --- > include/linux/usb/typec.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h > index d91e09d9d91c..4a9608a15ac1 100644 > --- a/include/linux/usb/typec.h > +++ b/include/linux/usb/typec.h > @@ -76,16 +76,10 @@ enum typec_orientation { > * struct enter_usb_data - Enter_USB Message details > * @eudo: Enter_USB Data Object > * @tbt_cable_vdo: TBT3 Cable Discover Mode Response > - * @active_link_training: Active Cable Plug Link Training > - * > - * @active_link_training is a flag that should be set with uni-directional SBRX > - * communication, and left 0 with passive cables and with bi-directional SBRX > - * communication. > */ > struct enter_usb_data { > u32 eudo; > u32 tbt_cable_vdo; > - unsigned char active_link_training:1; > }; > > /* > -- > 2.17.1
thanks,
-- heikki
| |