Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 18 Nov 2020 02:17:09 +0100 | Subject | Re: [PATCH v2 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure |
| |
On Tue, Nov 17, 2020 at 6:49 PM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> In the case of failure while parsing the partitions, the iterator should > be pre decremented by one before starting to free the memory allocated > by kstrdup(). Because in the failure case, kstrdup() will not succeed > and thus no memory will be allocated for the current iteration. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Good find! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |