lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [LINUX PATCH V3 3/9] gpio: gpio-xilinx: Add clock support
    On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli
    <srinivas.neeli@xilinx.com> wrote:

    > Adds clock support to the Xilinx GPIO driver.
    >
    > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

    (...)
    > + chip->clk = devm_clk_get_optional(&pdev->dev, NULL);
    > + if (IS_ERR(chip->clk)) {
    > + if (PTR_ERR(chip->clk) != -EPROBE_DEFER)
    > + dev_dbg(&pdev->dev, "Input clock not found\n");
    > + return PTR_ERR(chip->clk);
    > + }

    You can now use return dev_err_probe(dev, ret, "failed to get clock\n");
    to avoid all the comparing with -EPROBE_DEFER.

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2020-11-18 00:54    [W:4.565 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site