Messages in this thread | | | Date | Tue, 17 Nov 2020 16:22:23 -0500 (EST) | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] tracepoint: Do not fail unregistering a probe due to memory allocation |
| |
----- On Nov 17, 2020, at 3:58 PM, rostedt rostedt@goodmis.org wrote:
> On Tue, 17 Nov 2020 15:34:51 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: [...]
> If it comes down to not trusting calling a stub, I'll still keep the stub > logic in, and just add the following:
If we don't call the stub, then there is no point in having the stub at all, and we should just compare to a constant value, e.g. 0x1UL. As far as I can recall, comparing with a small immediate constant is more efficient than comparing with a loaded value on many architectures.
Thanks,
Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
| |