lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracepoint: Do not fail unregistering a probe due to memory allocation
----- On Nov 17, 2020, at 3:58 PM, rostedt rostedt@goodmis.org wrote:

> On Tue, 17 Nov 2020 15:34:51 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
[...]

> If it comes down to not trusting calling a stub, I'll still keep the stub
> logic in, and just add the following:

If we don't call the stub, then there is no point in having the stub at
all, and we should just compare to a constant value, e.g. 0x1UL. As far
as I can recall, comparing with a small immediate constant is more efficient
than comparing with a loaded value on many architectures.

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

\
 
 \ /
  Last update: 2020-11-17 22:24    [W:0.178 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site