Messages in this thread | | | Date | Tue, 17 Nov 2020 13:16:19 -0800 | From | Prashant Malani <> | Subject | Re: [PATCH v2 5/8] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message |
| |
Hi Utkarsh,
On Fri, Nov 13, 2020 at 12:25:00PM -0800, Utkarsh Patel wrote: > USB4 also uses same cable properties as Thunderbolt 3 so use Thunderbolt 3 > cable discover mode VDO to fill details such as active cable plug link > training and cable rounded support. > > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > > -- > Changes in v2: > - No change. > -- > --- > include/linux/usb/typec.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h > index 6be558045942..d91e09d9d91c 100644 > --- a/include/linux/usb/typec.h > +++ b/include/linux/usb/typec.h > @@ -75,6 +75,7 @@ enum typec_orientation { > /* > * struct enter_usb_data - Enter_USB Message details > * @eudo: Enter_USB Data Object > + * @tbt_cable_vdo: TBT3 Cable Discover Mode Response > * @active_link_training: Active Cable Plug Link Training > * > * @active_link_training is a flag that should be set with uni-directional SBRX > @@ -83,6 +84,7 @@ enum typec_orientation { > */ > struct enter_usb_data { > u32 eudo; > + u32 tbt_cable_vdo;
Can we instead just include a field for the rounded cable support property , similar to what was done for active_link_training? That way this gets decoupled from whether a TBT VDO was present in the cable or not
> unsigned char active_link_training:1; > }; > > -- > 2.17.1 >
Best regards,
-Prashant
| |