Messages in this thread | | | Subject | Re: [PATCH v11 06/16] PCI/ERR: Simplify by using pci_upstream_bridge() | From | "Kuppuswamy, Sathyanarayanan" <> | Date | Tue, 17 Nov 2020 12:11:29 -0800 |
| |
On 11/17/20 11:19 AM, Sean V Kelley wrote: > Use pci_upstream_bridge() in place of dev->bus->self. No functional change > intended. > > [bhelgaas: split to separate patch] > Link: https://lore.kernel.org/r/20201002184735.1229220-6-seanvk.dev@oregontracks.org > Signed-off-by: Sean V Kelley <sean.v.kelley@intel.com> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > --- > drivers/pci/pcie/err.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c > index db149c6ce4fb..05f61da5ed9d 100644 > --- a/drivers/pci/pcie/err.c > +++ b/drivers/pci/pcie/err.c > @@ -159,7 +159,7 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, > */ > if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT || > pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM)) > - dev = dev->bus->self; > + dev = pci_upstream_bridge(dev); Makes it easier to read. > bus = dev->subordinate; > > pci_dbg(dev, "broadcast error_detected message\n"); >
-- Sathyanarayanan Kuppuswamy Linux Kernel Developer
| |