lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v11 06/16] PCI/ERR: Simplify by using pci_upstream_bridge()
    From
    Date


    On 11/17/20 11:19 AM, Sean V Kelley wrote:
    > Use pci_upstream_bridge() in place of dev->bus->self. No functional change
    > intended.
    >
    > [bhelgaas: split to separate patch]
    > Link: https://lore.kernel.org/r/20201002184735.1229220-6-seanvk.dev@oregontracks.org
    > Signed-off-by: Sean V Kelley <sean.v.kelley@intel.com>
    > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
    > ---
    > drivers/pci/pcie/err.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
    > index db149c6ce4fb..05f61da5ed9d 100644
    > --- a/drivers/pci/pcie/err.c
    > +++ b/drivers/pci/pcie/err.c
    > @@ -159,7 +159,7 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
    > */
    > if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
    > pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM))
    > - dev = dev->bus->self;
    > + dev = pci_upstream_bridge(dev);
    Makes it easier to read.
    > bus = dev->subordinate;
    >
    > pci_dbg(dev, "broadcast error_detected message\n");
    >

    --
    Sathyanarayanan Kuppuswamy
    Linux Kernel Developer

    \
     
     \ /
      Last update: 2020-11-17 21:15    [W:2.633 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site