Messages in this thread | | | Subject | Re: [PATCH v2 3/6] dt-bindings: ata: tegra: Convert binding documentation to YAML | From | Sowjanya Komatineni <> | Date | Tue, 17 Nov 2020 08:15:33 -0800 |
| |
On 11/16/20 7:00 AM, Rob Herring wrote: > On Fri, 13 Nov 2020 11:36:55 -0800, Sowjanya Komatineni wrote: >> This patch converts text based dt-binding document to YAML based >> dt-binding document. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> --- >> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ >> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- >> 2 files changed, 137 insertions(+), 44 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dts:27.31-32 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1364: dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1400065 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
Hi Rob,
make dt_binding_check shows other yaml warmings and didn't go thru tegra-ahci.yaml even with specifying DT_SHHEMA_FILES
But, When I do dtbs_check, I see Documentation/devicetree/bindings/processed-schema.json generated and also it passes for tegra-ahci.yaml
In v1 feedback discussion, you mentioned it should be good if dtbs_check passes.
Regards,
Sowjanya
>
| |