lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
(+ Marc)

On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@baozis.org> wrote:
>
> From: Chen Baozi <chenbaozi@phytium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
> drivers/irqchip/irq-sni-exiu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
> if (fwspec->param_count != 2)
> return -EINVAL;
> *hwirq = fwspec->param[0];
> - *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> + *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
> }
> return 0;
> }
> --
> 2.28.0
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

\
 
 \ /
  Last update: 2020-11-17 09:48    [W:0.093 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site