lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 126/255] spi: bcm2835: remove use of uninitialized gpio flags variable
    Date
    From: Martin Hundebøll <martin@geanix.com>

    commit bc7f2cd7559c5595dc38b909ae9a8d43e0215994 upstream.

    Removing the duplicate gpio chip select level handling in
    bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe
    use of such variable by passing default flags to
    gpiochip_request_own_desc().

    Fixes: 5e31ba0c0543 ("spi: bcm2835: fix gpio cs level inversion")
    Signed-off-by: Martin Hundebøll <martin@geanix.com>
    Link: https://lore.kernel.org/r/20201105090615.620315-1-martin@geanix.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-bcm2835.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/spi/spi-bcm2835.c
    +++ b/drivers/spi/spi-bcm2835.c
    @@ -1193,7 +1193,6 @@ static int bcm2835_spi_setup(struct spi_
    struct spi_controller *ctlr = spi->controller;
    struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr);
    struct gpio_chip *chip;
    - enum gpio_lookup_flags lflags;
    u32 cs;

    /*
    @@ -1261,7 +1260,7 @@ static int bcm2835_spi_setup(struct spi_

    spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select,
    DRV_NAME,
    - lflags,
    + GPIO_LOOKUP_FLAGS_DEFAULT,
    GPIOD_OUT_LOW);
    if (IS_ERR(spi->cs_gpiod))
    return PTR_ERR(spi->cs_gpiod);

    \
     
     \ /
      Last update: 2020-11-17 15:10    [W:2.726 / U:0.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site