Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] highmem: fix highmem for xtensa | Date | Mon, 16 Nov 2020 18:37:06 +0100 |
| |
Max,
On Mon, Nov 16 2020 at 06:47, Max Filippov wrote: > On Fri, Nov 13, 2020 at 2:34 PM Thomas Gleixner <tglx@linutronix.de> wrote: >> I agree that the top down mechanics is not really intuitive, but that >> does not justify the ifdeffery in the generic code. > > But then maybe xtensa did the right thing where everyone else just > copied the not really intuitive implementation? If nobody else cares > then maybe generic fix_to_virt/virt_to_fix can be changed for positive > indexing?
Which requires to change 9 architectures instead of one for a feature which is barely used nowadays and which we rather want to get rid of.
Thanks,
tglx
| |