Messages in this thread | | | Date | Mon, 16 Nov 2020 14:10:15 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data |
| |
Em Fri, Nov 13, 2020 at 10:38:28AM -0800, Ian Rogers escreveu: > On Fri, Sep 4, 2020 at 9:29 AM Arnaldo Carvalho de Melo <acme@kernel.org> > wrote: > > > Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu: > > > On Thu, Aug 27, 2020 at 12:00 AM kajoljain <kjain@linux.ibm.com> wrote: > > > > > > > > > > > > > > > > On 8/26/20 9:27 PM, Jiri Olsa wrote: > > > > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: > > > > >> This patch resolves some undefined behavior where variables in > > > > >> expr_id_data were accessed (for debugging) without being defined. To > > > > >> better enforce the tagged union behavior, the struct is moved into > > > > >> expr.c and accessors provided. Tag values (kinds) are explicitly > > > > >> identified. > > > > > > > > Reviewed-By: Kajol Jain<kjain@linux.ibm.com> > > > > > > > > Thanks, > > > > Kajol Jain > > > > >> > > > > >> Signed-off-by: Ian Rogers <irogers@google.com> > > > > > > > > > > great, thanks for doing this > > > > > > > > > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > > > > > > > > > jirka > > > > > > > > > > > Thanks for the reviews! Arnaldo could this get merged? Thanks! > > > > I'll get this and the other outstanding patches into perf/core soon as I > > got urgent stuff already merged by Linus, > > > > Thanks! > > > > - Arnaldo > > > > I just spotted this wasn't merged and will conflict with: > https://lore.kernel.org/lkml/20201113001651.544348-1-irogers@google.com/ > I can fix that patch when this lands.
Thanks, applied, will test build and push publicly today.
- Arnaldo
| |