Messages in this thread | | | Subject | Re: [PATCH v3] checkpatch: avoid COMMIT_LOG_LONG_LINE warning for signature tags | From | Joe Perches <> | Date | Mon, 16 Nov 2020 08:59:28 -0800 |
| |
On Mon, 2020-11-16 at 14:07 +0530, Aditya Srivastava wrote: > Currently checkpatch warns us for long lines in commits even for > signature tag lines.
Thanks Aditya.
Acked-by: Joe Perches <joe@perches.com>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2961,8 +2961,8 @@ sub process { > # file delta changes > $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ || > # filename then : > - $line =~ /^\s*(?:Fixes:|Link:)/i || > - # A Fixes: or Link: line > + $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i || > + # A Fixes: or Link: line or signature tag line > $commit_log_possible_stack_dump)) { > WARN("COMMIT_LOG_LONG_LINE", > "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
| |