lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] spmi: hi6421-spmi-pmic: move driver from staging
    On Mon, 16 Nov 2020 13:59:28 +0100, Mauro Carvalho Chehab wrote:
    > The Hisilicon 6421v600 SPMI driver is ready for mainstream.
    >
    > So, move it from staging.
    >
    > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    > ---
    > .../spmi/hisilicon,hisi-spmi-controller.yaml | 62 +++
    > MAINTAINERS | 7 +
    > drivers/spmi/Kconfig | 9 +
    > drivers/spmi/Makefile | 1 +
    > drivers/spmi/hisi-spmi-controller.c | 358 ++++++++++++++++++
    > drivers/staging/hikey9xx/Kconfig | 11 -
    > drivers/staging/hikey9xx/Makefile | 1 -
    > .../staging/hikey9xx/hisi-spmi-controller.c | 358 ------------------
    > .../hisilicon,hisi-spmi-controller.yaml | 62 ---
    > 9 files changed, 437 insertions(+), 432 deletions(-)
    > create mode 100644 Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
    > create mode 100644 drivers/spmi/hisi-spmi-controller.c
    > delete mode 100644 drivers/staging/hikey9xx/hisi-spmi-controller.c
    > delete mode 100644 drivers/staging/hikey9xx/hisilicon,hisi-spmi-controller.yaml
    >


    My bot found errors running 'make dt_binding_check' on your patch:

    yamllint warnings/errors:
    ./Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml:34:2: [warning] wrong indentation: expected 2 but found 1 (indentation)

    dtschema/dtc warnings/errors:
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml: 'additionalProperties' is a required property
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml: ignoring, error in schema:
    warning: no schema found in file: ./Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
    Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.example.dts:29.20-31.15: Warning (unit_address_vs_reg): /example-0/bus/spmi@fff24000/pmic@0: node has a unit name, but no reg or ranges property
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.example.dt.yaml: spmi@fff24000: pmic@0: 'reg' is a required property
    From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml


    See https://patchwork.ozlabs.org/patch/1400897

    The base for the patch is generally the last rc1. Any dependencies
    should be noted.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit.

    \
     
     \ /
      Last update: 2020-11-16 16:36    [W:2.508 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site