lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
From
Date
On 11/16/20 3:44 PM, Vincent MAILHOL wrote:
> On Mon. 16 Nov 2020 at 03:55, Marc Kleine-Budde wrote:
>> On 11/14/20 4:22 PM, Vincent Mailhol wrote:
>>> This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from
>>> ETAS GmbH (https://www.etas.com/en/products/es58x.php).
>>>
>>> Co-developed-by: Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>
>>> Signed-off-by: Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>
>>> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>>
>> The driver fails to compile with CONFIG_SYSFS switched off
>>
>> CC [M] drivers/net/can/usb/etas_es58x/es58x_core.o
>> drivers/net/can/usb/etas_es58x/es58x_core.c: In function ‘es58x_init_netdev’:
>> drivers/net/can/usb/etas_es58x/es58x_core.c:2380:32: error: ‘struct netdev_queue’ has no member named ‘dql’
>> 2380 | netdev_get_tx_queue(netdev, 0)->dql.min_limit =
>> | ^~
>
> Thanks, nice catch!
> CONFIG_SYSFS is an expert setting, I totally missed that one. Took me
> actually a couple of minutes navigating in the menuconfig to find how
> to remove the option.

me too :)

> The root cause is actually on CONFIG_BQL (which depends on
> CONFIG_SYSFS).
> Reference: https://elixir.bootlin.com/linux/latest/source/include/linux/netdevice.h#L636
>
> Will send a v7 patch right after.
>
> Out of curiosity, how did you find this? Did you find it during a code
> review or did you just happen to have a .config with CONFIG_SYSFS

During code review, I found that the dql had a ifdef CONFIG_SYSFS.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-16 16:09    [W:0.093 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site