Messages in this thread | | | Date | Mon, 16 Nov 2020 09:02:23 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v3 1/2] dt-bindings: Document the hi3559a clock bindings |
| |
On Sat, 14 Nov 2020 00:22:36 +0000, Dongjiu Geng wrote: > Add DT bindings documentation for hi3559a SoC clock. > > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > --- > .../clock/hisilicon,hi3559av100-clock.yaml | 65 +++++++ > include/dt-bindings/clock/hi3559av100-clock.h | 165 ++++++++++++++++++ > 2 files changed, 230 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml > create mode 100644 include/dt-bindings/clock/hi3559av100-clock.h >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dts:20.23-27.11: Warning (unit_address_vs_reg): /example-0/clock0: node has a reg or ranges property, but no unit name /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: compatible: ['hisilicon,hi3559av100-clock', 'syscon'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: compatible: Additional items are not allowed ('syscon' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: #reset-cells:0:0: 1 was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml
See https://patchwork.ozlabs.org/patch/1399891
The base for the patch is generally the last rc1. Any dependencies should be noted.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |