Messages in this thread | | | Subject | Re: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property | From | Richard Gong <> | Date | Mon, 16 Nov 2020 07:50:07 -0600 |
| |
Hi Tom,
On 11/14/20 9:59 AM, Tom Rix wrote: > > On 11/14/20 6:52 AM, Richard Gong wrote: >> Hi Tom, >> >>>> prior to OS boot up. >>>> - encrypted-fpga-config : boolean, set if the bitstream is encrypted >>>> +- authenticate-fpga-config : boolean, set if do bitstream authentication >>> >>> The list is mostly in alphabetical order so the new 'authenticate-... ' should go at the top. >>> >> >> The original list is not in alphabetical order. The order of partial-fpga-config, external-fpga-config and encrypted-fpga-config here follows the implementation in the of-fpga-region.c file. >> >> So authenticate-fpga-config should follow the way, correct? >> > This is why i say 'mostly' .. > > In general when listing options for a user to read, you should make it easy for them to find > > the option they are looking for. Ordering them alphabetically is an obvious but not the only > > way. I am not asking for you to fix the whole table, just what you are adding. If there is > > a better way to organize them please propose the method. >
How about put authenticate-fpga-config above partial-fpga-config? I would like to group all xxx-fpga-config flags together.
Regards, Richard
> Tom > >>> Improve what you mean by 'authentication' similar to my comment in the first patch. >>> >> >> Will do in the version 2 submission. >> >> Regards, >> Richard >> >>> Tom >>> >>>> - region-unfreeze-timeout-us : The maximum time in microseconds to wait for >>>> bridges to successfully become enabled after the region has been >>>> programmed. >>> >> >
| |